Fixes the c3.X instances to have the proper disk size #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -219,35 +219,35 @@ | |||
| 'id': 'c3.large', | |||
| 'name': 'Compute Optimized Large Instance', | |||
| 'ram': 3750, | |||
| 'disk': 16, | |||
| 'disk': 32, # x2 | |||
There was a problem hiding this comment.
I think you can remove all of the # x2 comments
There was a problem hiding this comment.
Its just so its easier to know that its actually 2 different disks. There is a couple of instances in the file which have the same comment, probably so people dont get confused like I was at first :D
There was a problem hiding this comment.
so it's 2 disks of 16 that make 32, or two disks of 32 ?
There was a problem hiding this comment.
2 total disks, same as it was here https://github.com/Itxaka/libcloud/blob/fix_aws_c3_instances_disks/libcloud/compute/drivers/ec2.py#L336
|
@Kami ? |
erjohnso
pushed a commit
to erjohnso/libcloud
that referenced
this pull request
Dec 1, 2014
Signed-off-by: Sebastien Goasguen <runseb@gmail.com> This closes apache#405
erjohnso
pushed a commit
to erjohnso/libcloud
that referenced
this pull request
Dec 1, 2014
Signed-off-by: Sebastien Goasguen <runseb@gmail.com> This closes apache#405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See subject