Fixed the loadbalancer method for cloudstack incl tests #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Runseb |
|
yep, saw it. looks good to me. I can merge it on wednesday.. |
|
LGTM, I applied it. Forgot to close the pull request. @jeroendekorte thanks, can you close the PR. |
|
@jeroendekorte can you close this. I applied your patch but cannot close the pr on github. |
|
Done, thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load balancer:
Updated the loadbalancer for Cloudstack since this was not working.
Compute:
Updated the list_images to check if a image size is returned or not. Some templates/images don't have a size.