Proxy_url & connection object fixes #578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy_url was not being passed to the base Connection class by the base NodeDriver. Within the vCouldNodeDriver a new connection class we being created with no custom variables rather than re-using the existing connection class. Signed-off-by: MrBasset <daniel.pool@gmail.com>
Missed changing a reference to a variable that has been removed.
|
Thanks. The changes look good to me. Looks like the build is failing - https://travis-ci.org/apache/libcloud/builds/80160975. Can you please fix this? |
|
Sorry, will look at what I've done wrong. |
Unit tests were failing as specific Connection classes were masking access to the proxy_url property of the base Connection class.
Fixing lint errors
Damn it ... I need to install lint ...
|
Kami, I've managed to get a green light on the build - sorry it took so long. It seems that by adding that parameter into the base connection class, has highlighted that a number of the vendor specific drivers also didn't pass down the proxy_url parameter. I'm not sure if explicitly defining the proxy_url is the best approach, or whether it would be better to use **kwargs etc? I'd assumed the former, hopefully this isn't a breaking change. If this change is too wide reaching I'm happy to take advice on how to better implement it. |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case that requires explicitly setting the proxy_url for accessing a vCloud API (as opposed to the default environment proxy). I noticed that the proxy_url was not being passed to the base Connection class by the base NodeDriver. I fixed this by adding the proxy_url into the constructor call where the connection class is created.
Also, within the vCouldNodeDriver a new connection class we being created with
no custom variables rather than re-using the existing connection class. Any custom values, such as the proxy_url, were not being passed to this new instance. By swapping to the self.connection class these variables are set.
I could not find any unit tests that would demonstrate this issue (I would assume that they would be integration tests anyway). So apologies that this fix does not have supporting tests.