LIBCLOUD-750 MCP2 deploy support #587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tonybaloney
commented
Sep 23, 2015
tonybaloney
commented
- Updated the create_node methods to support the new API, and there every datacenter.
- Updated all of the _to_x methods so that they don't lookup the locations for each iteration, significantly quickening the time to make queries for large accounts
- Updated the unit tests to reflect more production data
- The deploy returns the node id now
- Added support for filtering networks, image, network domain and vlan by location
Corrected dd-ap 'host'
…ive API throws error. Updated tests which weren't previously providing values. Added extra parameters to the list methods to filter by location. Optimised the way each of the calls gets the location by fetching it once for a collection instead of each iteration. Fixed the ID lookup of VLAN and Network Domain.
… changed), updated tests.
…ng (better performance)
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2015
…ive API throws error. Updated tests which weren't previously providing values. Added extra parameters to the list methods to filter by location. Optimised the way each of the calls gets the location by fetching it once for a collection instead of each iteration. Fixed the ID lookup of VLAN and Network Domain. Closes #587
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2015
… changed), updated tests. Closes #587
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2015
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2015
…ng (better performance) Closes #587
|
Looks good to me. Merged into trunk, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.