DimensionData: Adding in new methods/tests for backups #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :param storage_policy: The storage policy for the client | ||
| :type storage_policy: ``str`` | ||
|
|
||
| :param schedule_policy: The storage policy for the client |
There was a problem hiding this comment.
should be "The schedule policy for the client"
|
I'm unhappy with how the classes for backups objects are directly defined here instead of in the common library. I'm going to make this change as well. |
|
Added negative tests around the info call if backups don't exist. |
|
the additional changes look great. thanks @jadunham1 merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in ability to add clients to a target
Added in ability to list backup info for a target
Added in positive tests