adds dns support for ns1 provider #710

piratimir · 2016-02-22T15:38:20Z

The methods that deal with records are not finished yet.

tonybaloney · 2016-02-22T16:00:34Z

Thanks @jetbird for the PR. Let me know when this is completed. Also if you install flake8 locally you can run the code checks to pass the failing lint build job in travis.

piratimir · 2016-02-23T10:22:22Z

@tonybaloney @Kami I think we have a problem in implementing the def create_record(self, name, zone, type, data, extra=None) method. From what I understand when reading the API, the provider does not support adding a name for the new record.

Under Records take a look on the PUT method https://ns1.com/api/

Kami · 2016-02-23T11:42:34Z

@jetbird I checked the docs and it looks like you need to provide a fully qualified record name when creating a record.

This means record name + domain name. It looks like that in the docs they refer to the record name + domainname as "domain".

For example if record name is foo and domain name is example.com you would need to pass example.com for the zone and foo.example.com for domain.

piratimir · 2016-02-24T23:11:01Z

@Kami, you are right. Coding it now.

piratimir · 2016-02-25T10:31:18Z

@tonybaloney It is finished man. Please take a look at the code.

tonybaloney · 2016-02-26T17:51:39Z

@jetbird the lint is failing:
libcloud/common/nsone.py:20:80: E501 line too long (85 > 79 characters)
libcloud/common/nsone.py:23:80: E501 line too long (88 > 79 characters)
libcloud/dns/drivers/nsone.py:7:80: E501 line too long (80 > 79 characters)
libcloud/dns/drivers/nsone.py:8:80: E501 line too long (114 > 79 characters)
libcloud/dns/drivers/nsone.py:60:80: E501 line too long (90 > 79 characters)
libcloud/dns/drivers/nsone.py:79:80: E501 line too long (115 > 79 characters)
libcloud/dns/drivers/nsone.py:90:80: E501 line too long (91 > 79 characters)
libcloud/dns/drivers/nsone.py:93:80: E501 line too long (90 > 79 characters)
libcloud/dns/drivers/nsone.py:129:80: E501 line too long (90 > 79 characters)
libcloud/dns/drivers/nsone.py:132:80: E501 line too long (85 > 79 characters)
libcloud/dns/drivers/nsone.py:138:80: E501 line too long (92 > 79 characters)
libcloud/dns/drivers/nsone.py:140:80: E501 line too long (80 > 79 characters)
libcloud/dns/drivers/nsone.py:149:80: E501 line too long (96 > 79 characters)
libcloud/dns/drivers/nsone.py:164:80: E501 line too long (86 > 79 characters)
libcloud/dns/drivers/nsone.py:169:80: E501 line too long (96 > 79 characters)
libcloud/dns/drivers/nsone.py:189:80: E501 line too long (90 > 79 characters)
libcloud/dns/drivers/nsone.py:205:80: E501 line too long (91 > 79 characters)
libcloud/dns/drivers/nsone.py:208:80: E501 line too long (90 > 79 characters)
libcloud/dns/drivers/nsone.py:230:80: E501 line too long (90 > 79 characters)
libcloud/dns/drivers/nsone.py:243:80: E501 line too long (92 > 79 characters)
libcloud/dns/drivers/nsone.py:246:80: E501 line too long (89 > 79 characters)
libcloud/dns/drivers/nsone.py:277:80: E501 line too long (113 > 79 characters)

piratimir · 2016-02-27T13:24:24Z

@tonybaloney I managed to flake8 the code.

Kami · 2016-02-28T13:14:28Z

@jetbird Nice work so far 👍

The next step would be adding some tests and documentation :)

Kami · 2016-02-28T13:15:46Z

libcloud/dns/drivers/nsone.py

+        common_attr = ['zone', 'id', 'type']
+        extra = {}
+        for key in item:
+            if key not in common_attr:


I believe this should be if key in common_attr (dropping not)?

If a key is not in common_attr list then we add it in the extra dict as a key with the item.get('key') as value. The keys in common_attr are needed to build the Zone object. Why do you think we should drop it?

piratimir · 2016-03-09T12:31:46Z

@Kami @tonybaloney guys did you find some time to check the tests?

tonybaloney · 2016-03-09T23:19:53Z

libcloud/test/dns/test_nsone.py

+
+from libcloud.test import MockHttp
+from libcloud.test.file_fixtures import DNSFileFixtures
+from libcloud.test.secrets import DNS_PARAMS_NSONE


This does not exist, you need to update test/secrets-dist.py

@tonybaloney I thought DNS_PARAMS_NSONE is supposed to stay locally?

@tonybaloney I updated and pushed secrets.py. I do not know why the travis builds are failing. The tests pass when run on my local machine.

tonybaloney · 2016-03-15T22:57:04Z

@jetbird secrets.py is on the ignore list, part of the build is to copy secrets-dist.py to secrets.py. You need to apply your changes to secrets-dist and apply those changes. Not secrets.py

piratimir · 2016-03-15T23:02:15Z

@tonybaloney Done.

tonybaloney · 2016-03-15T23:02:50Z

Excellent, thats the one. If CI gives the 🍏 then I will merge. LGTM

piratimir · 2016-03-15T23:06:26Z

@tonybaloney It does not look like that. I also updated the fixtures with blank lines at each one of them, but when pushing on github they get ignored.

tonybaloney · 2016-03-15T23:07:12Z

@jetbird except NsOneException, e: is not a valid syntax in Python 3.

Do you have Tox? This would really help you testing before you commit.

piratimir · 2016-03-15T23:09:36Z

@tonybaloney I will install it now.

piratimir · 2016-03-15T23:20:45Z

@tonybaloney I installed tox and ran the tests with sudo tox, but the problem is that many interpreters are not found. I am not familiar with tox, so I guess I need to read the docs. Where should I install these interpreters?

Is the following the only problem or are there more. Because if it is the only one I can fix this and take care later about the tox?

except NsOneException, e: is not a valid syntax in Python 3.

tonybaloney · 2016-03-15T23:30:41Z

@jetbird you can review the errors here https://travis-ci.org/apache/libcloud/builds/116256818

piratimir · 2016-03-15T23:34:17Z

@tonybaloney I decided to follow this approach to keep one code base through different versions of python.

  try:
       response = self.connection.request(action=action, method='GET')
  except NsOneException:
       e = sys.exc_info()[1]

Now will try to pass the tests with tox.

tonybaloney · 2016-03-15T23:39:07Z

Use tox -e py34 as an example to just test 3.4. You don't need to install every possible version, just at least 2.7 and 3.4+.

piratimir · 2016-03-16T00:08:34Z

@tonybaloney I get the following output when running the command.

lostbird@lostbird:~/projects/libcloud$ sudo tox -e py34
GLOB sdist-make: /home/lostbird/projects/libcloud/setup.py
py34 create: /home/lostbird/projects/libcloud/.tox/py34
ERROR: InterpreterNotFound: 
____________________________________________________________________________ summary _____________________________________________________________________________
ERROR:   py34: InterpreterNotFound:

piratimir · 2016-03-16T00:55:15Z

@tonybaloney I managed to run the tests against python3.4 and they pass. The only check that is failing on travis is the lint check. Maybe it is the fixtures, I have no idea. Thanks for being so patient and helping.

https://travis-ci.org/apache/libcloud/builds/116270772

piratimir · 2016-03-16T18:17:48Z

@Kami @tonybaloney Hey guys when using flake8 on nsone module and test_nsone I do not get any errors. Why do you think the lint build job in travis is failing?

piratimir · 2016-03-18T21:03:53Z

@tonybaloney @Kami any update on this please?

tonybaloney · 2016-03-21T09:38:07Z

libcloud/test/dns/test_nsone.py

+from libcloud.dns.drivers.nsone import NsOneDNSDriver
+from libcloud.utils.py3 import httplib
+from libcloud.dns.types import ZoneDoesNotExistError, ZoneAlreadyExistsError,\
+    RecordDoesNotExistError,  RecordType


There are 2 spaces after the comma. this is failing the lint. remove one of the spaces and just commit that change then we're good to go @jetbird

Ok man :) 👍

piratimir · 2016-03-21T10:01:41Z

@tonybaloney I removed the extra spaces, but it still fails.

tonybaloney · 2016-03-21T10:05:51Z

@jetbird so close!! libcloud/test/dns/test_nsone.py:10:2: E121 continuation line under-indented for hanging indent

tonybaloney · 2016-03-21T10:19:04Z

yeah!!

piratimir · 2016-03-21T10:19:12Z

@tonybaloney finally 👯

tonybaloney · 2016-03-21T10:23:50Z

Merged. Thanks @jetbird it might be time to get a Python editor with a built in linter! Try Komodo or Atom :-)

piratimir · 2016-03-21T10:25:18Z

@tonybaloney Thanks for the help and support 👍 I am using pycharm and flake8 is not working ok. I installed pylint via pip. I will be contributing again, so please if you can give me your email address would be great :)

adds dns support for ns1 provider

efbfddd

implements delete_record method

27ad604

implements record methods

c665bfb

flake8 the code

25b143b

Kami reviewed Feb 28, 2016
View reviewed changes

lostbird added 3 commits February 29, 2016 17:17

fixes iteration over keys in _to_zone, _to_record

c0745f3

adds unittest for nsone dns driver

24fea05

adds unittests for nsone driver

7872d48

tonybaloney reviewed Mar 9, 2016
View reviewed changes

lostbird added 3 commits March 15, 2016 23:03

flake8 the tests code

68fdec8

fixes tests to pass

fd37d06

adds secrets.py

bc64c5c

updates test/secrets-dist

1d9e76f

fixes except syntax to suppot python3

3883776

tonybaloney reviewed Mar 21, 2016
View reviewed changes

lostbird added 3 commits March 21, 2016 10:47

fixes the lint

a032f79

removes extra space

4b90a94

fixes lint

873e64e

fixes lint

7070f94

asfgit closed this in 4806a6a Mar 21, 2016

adds dns support for ns1 provider #710

adds dns support for ns1 provider #710

Conversation

piratimir commented Feb 22, 2016

tonybaloney commented Feb 22, 2016

piratimir commented Feb 23, 2016

Kami commented Feb 23, 2016

piratimir commented Feb 24, 2016

piratimir commented Feb 25, 2016

tonybaloney commented Feb 26, 2016

piratimir commented Feb 27, 2016

Kami commented Feb 28, 2016

Kami Feb 28, 2016

Choose a reason for hiding this comment

piratimir Feb 29, 2016

Choose a reason for hiding this comment

piratimir commented Mar 9, 2016

tonybaloney Mar 9, 2016

Choose a reason for hiding this comment

piratimir Mar 10, 2016

Choose a reason for hiding this comment

piratimir Mar 15, 2016

Choose a reason for hiding this comment

tonybaloney commented Mar 15, 2016

piratimir commented Mar 15, 2016

tonybaloney commented Mar 15, 2016

piratimir commented Mar 15, 2016

tonybaloney commented Mar 15, 2016

piratimir commented Mar 15, 2016

piratimir commented Mar 15, 2016

tonybaloney commented Mar 15, 2016

piratimir commented Mar 15, 2016

tonybaloney commented Mar 15, 2016

piratimir commented Mar 16, 2016

piratimir commented Mar 16, 2016

piratimir commented Mar 16, 2016

piratimir commented Mar 18, 2016

tonybaloney Mar 21, 2016

Choose a reason for hiding this comment

piratimir Mar 21, 2016

Choose a reason for hiding this comment

piratimir commented Mar 21, 2016

tonybaloney commented Mar 21, 2016

tonybaloney commented Mar 21, 2016

piratimir commented Mar 21, 2016

tonybaloney commented Mar 21, 2016

piratimir commented Mar 21, 2016