Add libcloud support for image guest os features. #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4752,29 +4753,31 @@ def ex_copy_image(self, name, url, description=None, family=None, | |||
| :param family: The family of the image | |||
| :type family: ``str`` | |||
|
|
|||
| :param guest_os_feature: The features of the guest opertaing system. | |||
| :type guest_os_feature: ``str`` | |||
| :param guest_os_features: The features of the guest opertaing system. | |||
|
LGTM, couple of spelling errors I noted. |
| if guest_os_features: | ||
| image_data['guestOsFeatures'] = [] | ||
| for feature in guest_os_features: | ||
| if feature in possble_features: |
There was a problem hiding this comment.
that should be for feature in possible_features: and also showing this case needs a test :-)
There was a problem hiding this comment.
Yup, thanks for the note. I missed the typo (and failing test) when I refactored some of the code).
|
@illfelder 1 typo to correct and please also improve the test scenario to validate the outgoing payload. |
Guest OS features are a repeated field in the API.
|
Added testing to validate the request is getting created properly. I also fixed a comment about the type of guest_os_features when creating an image. |
|
@illfelder think you broke the build with the extra commit :-) |
|
Yup, fixed the linter issue. Should be good now whenever travis next runs. |
|
OK 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image "guestOsFeature" support during image copy and creation.
Description
We are introducing a new optional property on the image resource known as "guestOsFeature". The feature is available in the alpha API and is needed to optimize virtual machine settings during instance creation. The only value currently supported (if specified) is "VIRTIO_SCSI_MULTIQUEUE".
Status
Done, ready for review
Checklist (tick everything that applies)