[LIBCLOUD-917] Gandi compute driver should use a unique location name #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.002%) to 88.221% when pulling ff021f7 on Gandi:LIBCLOUD-917_gandi_unique_location_name into f3c7474 on apache:trunk. |
|
Thanks for your contribution @sayoun 👍 |
|
@tonybaloney Do I need to submit a git patch on the JIRA Issue or I can just close the JIRA issue associated with this PR ? |
|
@sayoun just close the JIRA issue if you're happy with the outcome |
|
yep it's great, thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gandi compute driver uses a non unique field value as name for locations
See JIRA ticket https://issues.apache.org/jira/browse/LIBCLOUD-917
Status
Checklist (tick everything that applies)