Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow location of the data center to be supplied #635

Closed
wants to merge 1 commit into from

Conversation

@joelreymont
Copy link
Contributor

joelreymont commented Nov 18, 2015

No description provided.

@tonybaloney
Copy link
Contributor

tonybaloney commented Nov 18, 2015

ok, great. I'll merge + close

@joelreymont
Copy link
Contributor Author

joelreymont commented Nov 18, 2015

Do I need to open issues in the future, e.g.
https://issues.apache.org/jira/browse/LIBCLOUD-771 ?

On Wed, Nov 18, 2015 at 11:54 PM Anthony Shaw notifications@github.com
wrote:

ok, great. I'll merge + close


Reply to this email directly or view it on GitHub
#635 (comment).

@asfgit asfgit closed this in 3415ef2 Nov 18, 2015
@tonybaloney
Copy link
Contributor

tonybaloney commented Nov 18, 2015

Yes, keep opening the tickets, they should get closed automatically, it's good to keep a record.
https://libcloud.readthedocs.org/en/latest/development.html#contribution-workflow
Also, you'll see the notes in there about maintaining branches in your own fork for each ticket, which is also good practice and comes in handy if a PR isn't closed and you want to open another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.