New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement block storage APIs for DigitalOcean #807

Closed
wants to merge 5 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@adamwg
Contributor

adamwg commented Jun 7, 2016

Implement block storage APIs for DigitalOcean

Description

DigitalOcean has a new block storage feature in beta. The API docs are available here. This PR implements the block storage API calls in the DigitalOcean driver.

A few things to keep in mind at this point:

  • Block storage is currently only available to users enrolled in the beta. Block storage API calls will fail for other users.
  • Block storage is not yet available in all DigitalOcean regions.
  • DigitalOcean block storage does not support snapshots, so snapshot-related APIs are still unimplemented.

Status

Done, ready for review.

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jun 9, 2016

Contributor

Cool, great contribution! LGTM 👍 for adding tests too

Contributor

tonybaloney commented Jun 9, 2016

Cool, great contribution! LGTM 👍 for adding tests too

@adamwg

This comment has been minimized.

Show comment
Hide comment
@adamwg

adamwg Jun 10, 2016

Contributor

Thanks!

FYI, there is a breaking change to the DO block storage API coming in the next couple weeks (like I said, the feature is in beta). If you'd like to merge this now I'll submit a follow-up PR when the API change happens, or if you'd like to hold off I'll update this PR after the change.

Contributor

adamwg commented Jun 10, 2016

Thanks!

FYI, there is a breaking change to the DO block storage API coming in the next couple weeks (like I said, the feature is in beta). If you'd like to merge this now I'll submit a follow-up PR when the API change happens, or if you'd like to hold off I'll update this PR after the change.

@adamwg

This comment has been minimized.

Show comment
Hide comment
@adamwg

adamwg Jun 23, 2016

Contributor

The breaking API change I mentioned went live this afternoon, so I've just pushed a new version of my branch that complies with the new API. We're not expecting the API to change again, so it should be safe to merge this any time.

Let me know if there are any changes I should make, or some more process I need to go through to get this merged :-).

Contributor

adamwg commented Jun 23, 2016

The breaking API change I mentioned went live this afternoon, so I've just pushed a new version of my branch that complies with the new API. We're not expecting the API to change again, so it should be safe to merge this any time.

Let me know if there are any changes I should make, or some more process I need to go through to get this merged :-).

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jun 24, 2016

Contributor

Thanks @adamwg changes look good. merging.

Contributor

tonybaloney commented Jun 24, 2016

Thanks @adamwg changes look good. merging.

@asfgit asfgit closed this in f1c2361 Jun 24, 2016

asfgit pushed a commit that referenced this pull request Jun 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment