Implement block storage APIs for DigitalOcean #807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, great contribution! LGTM 👍 for adding tests too |
|
Thanks! FYI, there is a breaking change to the DO block storage API coming in the next couple weeks (like I said, the feature is in beta). If you'd like to merge this now I'll submit a follow-up PR when the API change happens, or if you'd like to hold off I'll update this PR after the change. |
|
The breaking API change I mentioned went live this afternoon, so I've just pushed a new version of my branch that complies with the new API. We're not expecting the API to change again, so it should be safe to merge this any time. Let me know if there are any changes I should make, or some more process I need to go through to get this merged :-). |
|
Thanks @adamwg changes look good. merging. |
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement block storage APIs for DigitalOcean
Description
DigitalOcean has a new block storage feature in beta. The API docs are available here. This PR implements the block storage API calls in the DigitalOcean driver.
A few things to keep in mind at this point:
Status
Done, ready for review.
Checklist (tick everything that applies)