Fix image undeprecation in GCE #852

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@illfelder
Contributor

illfelder commented Aug 11, 2016

Fix image undeprecation in GCE

Description

An empty request body in a deprecation POST request will undeprecate the image. Specifying the "ACTIVE" state preserves the current "DEPRECATE" default.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@illfelder illfelder referenced this pull request Aug 12, 2016

Closed

Allow undeprecation of an image. #851

1 of 4 tasks complete
@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Aug 12, 2016

Member

Thanks @illfelder! Could you help improve testing a bit around images and cover this change? https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/test_gce.py#L1177

Member

erjohnso commented Aug 12, 2016

Thanks @illfelder! Could you help improve testing a bit around images and cover this change? https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/test_gce.py#L1177

@illfelder

This comment has been minimized.

Show comment
Hide comment
@illfelder

illfelder Aug 12, 2016

Contributor

I've played around with testing and spoken about it with @wrigri. It appears that existing tests for libcloud only verify that the correct API is called, not the body of the request. As a result, we can't find a supported way to verify that using "ACTION" translates to an empty request body. If you know of one, please let us know.

Contributor

illfelder commented Aug 12, 2016

I've played around with testing and spoken about it with @wrigri. It appears that existing tests for libcloud only verify that the correct API is called, not the body of the request. As a result, we can't find a supported way to verify that using "ACTION" translates to an empty request body. If you know of one, please let us know.

@asfgit asfgit closed this in 0846fe4 Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment