Fix image undeprecation in GCE #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illfelder
force-pushed
the
trunk
branch
2 times, most recently
from
2bc07a7
to
f2a7c62
Compare
4 tasks
|
Thanks @illfelder! Could you help improve testing a bit around images and cover this change? https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/test_gce.py#L1177 |
|
I've played around with testing and spoken about it with @wrigri. It appears that existing tests for libcloud only verify that the correct API is called, not the body of the request. As a result, we can't find a supported way to verify that using "ACTION" translates to an empty request body. If you know of one, please let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix image undeprecation in GCE
Description
An empty request body in a deprecation POST request will undeprecate the image. Specifying the "ACTIVE" state preserves the current "DEPRECATE" default.
Status
Checklist (tick everything that applies)