Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image undeprecation in GCE #852

Closed
wants to merge 1 commit into from
Closed

Fix image undeprecation in GCE #852

wants to merge 1 commit into from

Conversation

@illfelder
Copy link
Contributor

@illfelder illfelder commented Aug 11, 2016

Fix image undeprecation in GCE

Description

An empty request body in a deprecation POST request will undeprecate the image. Specifying the "ACTIVE" state preserves the current "DEPRECATE" default.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@illfelder illfelder force-pushed the trunk branch 2 times, most recently from 2bc07a7 to f2a7c62 Aug 12, 2016
@erjohnso
Copy link
Member

@erjohnso erjohnso commented Aug 12, 2016

Thanks @illfelder! Could you help improve testing a bit around images and cover this change? https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/test_gce.py#L1177

@illfelder
Copy link
Contributor Author

@illfelder illfelder commented Aug 12, 2016

I've played around with testing and spoken about it with @wrigri. It appears that existing tests for libcloud only verify that the correct API is called, not the body of the request. As a result, we can't find a supported way to verify that using "ACTION" translates to an empty request body. If you know of one, please let us know.

@asfgit asfgit closed this in 0846fe4 Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants