Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix image undeprecation in GCE #852
Fix image undeprecation in GCE
An empty request body in a deprecation POST request will undeprecate the image. Specifying the "ACTIVE" state preserves the current "DEPRECATE" default.
Checklist (tick everything that applies)
Thanks @illfelder! Could you help improve testing a bit around images and cover this change? https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/test_gce.py#L1177
I've played around with testing and spoken about it with @wrigri. It appears that existing tests for libcloud only verify that the correct API is called, not the body of the request. As a result, we can't find a supported way to verify that using "ACTION" translates to an empty request body. If you know of one, please let us know.