LIBCLOUD-858: Fix Listing Libvirt Nodes with Python 3 #894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Listing Libvirt Nodes with Python 3
Description
Listing nodes with the
Libvirt
provider fails on Python 3 because of asplit
operation on abytes
object where the delimiter is not abytes
object.Use the
ensure_string
function from thepy3
module to ensure that the output of asubprocess.Popen
call is always a string for Python 2 and 3. Also add a test to convert the mock command output results tobytes
objects if the active Python version is 3.Status
Checklist (tick everything that applies)