/libcloud

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapshot management to OVH compute #897

Merged
merged 3 commits into from Oct 11, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ZuluPro @tonybaloney @asfgit
@ZuluPro
Contributor

ZuluPro commented Oct 9, 2016 •
edited

Added snapshot management to OVH compute

Description

Added:

  • ex_list_snapshots
  • ex_get_volume_snapshot
  • list_volume_snapshots
  • create_volume_snapshot
  • destroy_volume_snapshot

I also improved docstrings, sort argument base on BaseNodeDriver and add the prefix ex_ to custom argument.

Status

WIP, missing docstring and arguments checking.

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 9, 2016

Contributor

@ZuluPro thanks for the contribution, https://travis-ci.org/apache/libcloud/jobs/166278948 a few linting errors in the tests file to cleanup.
Contributor

tonybaloney commented Oct 9, 2016

@ZuluPro thanks for the contribution, https://travis-ci.org/apache/libcloud/jobs/166278948 a few linting errors in the tests file to cleanup.
@ZuluPro

This comment has been minimized.

Show comment
Hide comment
@ZuluPro

ZuluPro Oct 10, 2016

Contributor

@tonybaloney Fixed !
Contributor

ZuluPro commented Oct 10, 2016

@tonybaloney Fixed !
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Oct 11, 2016

Contributor

👍 changes look good.
Contributor

tonybaloney commented Oct 11, 2016

👍 changes look good.

@asfgit asfgit merged commit 557fd76 into apache:trunk Oct 11, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

asfgit pushed a commit that referenced this pull request Oct 11, 2016

@tonybaloney
Merge branch 'libcloud-897' into trunk 
Closes #897
d6d98d0

asfgit pushed a commit that referenced this pull request Oct 11, 2016

@tonybaloney
Changes for #897
Verified
This commit was signed with a verified signature.
@tonybaloney tonybaloney Anthony Shaw
GPG key ID: AB4A19AE1CE85744 Learn about signing commits
26671fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment