Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapshot management to OVH compute #897

Merged
merged 3 commits into from Oct 11, 2016
Merged

Conversation

@ZuluPro
Copy link
Contributor

ZuluPro commented Oct 9, 2016

Added snapshot management to OVH compute

Description

Added:

  • ex_list_snapshots
  • ex_get_volume_snapshot
  • list_volume_snapshots
  • create_volume_snapshot
  • destroy_volume_snapshot

I also improved docstrings, sort argument base on BaseNodeDriver and add the prefix ex_ to custom argument.

Status

WIP, missing docstring and arguments checking.

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@tonybaloney
Copy link
Contributor

tonybaloney commented Oct 9, 2016

@ZuluPro thanks for the contribution, https://travis-ci.org/apache/libcloud/jobs/166278948 a few linting errors in the tests file to cleanup.

@ZuluPro ZuluPro force-pushed the ZuluPro:ovh_compute branch from 0124f76 to 557fd76 Oct 10, 2016
@ZuluPro
Copy link
Contributor Author

ZuluPro commented Oct 10, 2016

@tonybaloney Fixed !

@tonybaloney
Copy link
Contributor

tonybaloney commented Oct 11, 2016

👍 changes look good.

@asfgit asfgit merged commit 557fd76 into apache:trunk Oct 11, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
asfgit pushed a commit that referenced this pull request Oct 11, 2016
asfgit pushed a commit that referenced this pull request Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.