add ex_change_kernel in DigitalOcean_v2 driver #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
reviewed
Oct 24, 2016
| @@ -154,6 +154,12 @@ def test_destroy_node_success(self): | |||
| result = self.driver.destroy_node(node) | |||
| self.assertTrue(result) | |||
|
|
|||
| def test_ex_change_kernel_success(self): | |||
| node = self.driver.list_nodes()[0] | |||
| DigitalOceanMockHttp.type = 'KERNELCHANGE' | |||
There was a problem hiding this comment.
"AttributeError: 'DigitalOceanMockHttp' object has no attribute '_v2_droplets_3164444_actions_KERNELCHANGE'"
| @@ -271,6 +277,11 @@ def _v2_droplets_3164444_DESTROY(self, method, url, body, headers): | |||
| return (httplib.NO_CONTENT, body, {}, | |||
| httplib.responses[httplib.NO_CONTENT]) | |||
|
|
|||
| def _v2_droplets_3164444_actions_CHANGEKERNEL(self, method, url, body, headers): | |||
There was a problem hiding this comment.
that should be KERNELCHANGE, not CHANGEKERNEL
> To change the kernel of a Droplet, send a POST request to > /v2/droplets/$DROPLET_ID/actions. Set the "type" attribute to > change_kernel and the "kernel" attribute to the new kernel's ID. https://developers.digitalocean.com/documentation/v2/#change-the-kernel
vdloo
force-pushed
the
implement-ex-change-kernel
branch
from
0f4d52d
to
0137585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ex_change_kernel in DigitalOcean_v2 driver
So the kernel can be managed using the API
https://developers.digitalocean.com/documentation/v2/#change-the-kernel
The
DigitalOcean GrubLoadercan also be set with this allowing for Internal Kernel Management in a Droplet.