DD - Update default api version #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning status and version status attributes
tonybaloney
reviewed
Dec 27, 2016
| "ex_tagid_value_pairs must be a dictionary." | ||
| ) | ||
|
|
||
| if sys.version_info[0] < 3: |
There was a problem hiding this comment.
http://python-future.org/compatible_idioms.html#iterating-through-dict-keys-values-items in future, this is the correct way to do it in Py2/3
| "ex_tagname_value_pairs must be a dictionary" | ||
| ) | ||
|
|
||
| if sys.version_info[0] < 3: |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DD - Promote 2.4 as default api version and some parameter validation.
Description
Make 2.4 the default version.
Validate create_node method ex_is_started parameter is a bool, otherwise set to True by default.
For more information on contributing, please see Contributing
section of our documentation.
Status
Checklist (tick everything that applies)