Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring LibcloudConnection and Connection classes from feedback #976

merged 8 commits into from Jan 13, 2017


Copy link

tonybaloney commented Jan 13, 2017

Issues Raised:

  • Use URLJoin instead of ''.join : #923 (comment) raised by @allardhoeve
  • Create a test to ensure creating Connection instances with a trailing / and then using request with a method with a leading / does not create malformed URL requests
  • Make allow_redirects configurable (but true by default?) #923 (comment) @allardhoeve
  • Move verification logic into property in LibcloudConnection #923 (comment)
  • Fix if/else in hash buffer code #923 (comment)
  • Remove SSL/TLS error messages and custom socket.error handling code as it's no longer needed
tonybaloney added 8 commits Jan 13, 2017
…quest actions start with /. Urlparse instead of ''.join
…cenarion works as expected
Copy link
Contributor Author

tonybaloney commented Jan 13, 2017


@asfgit asfgit merged commit ee5a227 into apache:trunk Jan 13, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
asfgit pushed a commit that referenced this pull request Jan 13, 2017
asfgit pushed a commit that referenced this pull request Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.