New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring LibcloudConnection and Connection classes from feedback #976

Merged
merged 8 commits into from Jan 13, 2017

Conversation

Projects
None yet
2 participants
@tonybaloney
Contributor

tonybaloney commented Jan 13, 2017

Issues Raised:

  • Use URLJoin instead of ''.join : #923 (comment) raised by @allardhoeve
  • Create a test to ensure creating Connection instances with a trailing / and then using request with a method with a leading / does not create malformed URL requests
  • Make allow_redirects configurable (but true by default?) #923 (comment) @allardhoeve
  • Move verification logic into property in LibcloudConnection #923 (comment)
  • Fix if/else in hash buffer code #923 (comment)
  • Remove SSL/TLS error messages and custom socket.error handling code as it's no longer needed

tonybaloney added some commits Jan 13, 2017

fix a bug where creating a connection from URL would not work when re…
…quest actions start with /. Urlparse instead of ''.join
@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Jan 13, 2017

Contributor

merging

Contributor

tonybaloney commented Jan 13, 2017

merging

@asfgit asfgit merged commit ee5a227 into apache:trunk Jan 13, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

asfgit pushed a commit that referenced this pull request Jan 13, 2017

asfgit pushed a commit that referenced this pull request Jan 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment