Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugFix:unified the width of all instance related field to be 128. #1053

Conversation

lunescode
Copy link
Contributor

What is the purpose of the change

Iin table linkis_cg_manager_service_instance and table linkis_cg_manager_service_instance_metrics, 'instance' is 128,but in linkis_ps_instance_label_relation(service_instance)、linkis_cg_manager_label_service_instance(service_instance)、linkis_cg_manager_engine_em(engine_instance、em_instance) is 64.
if hostname use fqdn, then length will longer than 64,such as 'linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local'

Brief change log

  • modify linkis_ps_instance_label_relation(service_instance) 64->128 ;
  • modify linkis_cg_manager_label_service_instance(service_instance) 64->128;
  • modify linkis_cg_manager_engine_em(engine_instance、em_instance) 64->128;

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: ( no )
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

reason: in table linkis_cg_manager_service_instance and table linkis_cg_manager_service_instance_metrics, 'instance' is 128,but in linkis_ps_instance_label_relation(service_instance)、linkis_cg_manager_label_service_instance(service_instance)、linkis_cg_manager_engine_em(engine_instance、em_instance) is 64.
if hostname use fqdn, then length will longer than 64,such as 'linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local'
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 47bf4c5 into apache:dev-1.0.3 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants