Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugFix:instance Label parase failed when hostname contains servicename. #1054

Merged

Conversation

lunescode
Copy link
Contributor

@lunescode lunescode commented Oct 29, 2021

What is the purpose of the change

bugFix:instance Label Parase failed when hostname contains servicename.
for example,
hostname: linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local
serviceName:linkis-cg-engineconnmanager
str:linkis-cg-engineconnmanager-linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local:9104
after setStringValue:
instance = -0.linkis-svc.default.svc.cluster.local:9104
correct value should be: linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local:9104

Brief change log

  • replace replace with replaceFirst in EMInstanceLabel.java and EngineInstanceLabel.java

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: ( no )
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

for example,
hostname: linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local
serviceName:linkis-cg-engineconnmanager
str:linkis-cg-engineconnmanager-linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local:9104
after setStringValue:
instance = -0.linkis-svc.default.svc.cluster.local:9104
correct value should be: linkis-cg-engineconnmanager-0.linkis-svc.default.svc.cluster.local:9104
@lunescode lunescode changed the title bugFix:instance Label Parase failed when hostname contains serciename. bugFix:instance Label Parase failed when hostname contains servicename. Oct 30, 2021
@lunescode lunescode changed the title bugFix:instance Label Parase failed when hostname contains servicename. bugFix:instance Label parase failed when hostname contains servicename. Oct 30, 2021
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 4c5c8aa into apache:dev-1.0.3 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants