Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafka,json and hadoop-mapreduce-client-core jar in flink engine #1069

Merged
merged 1 commit into from Nov 22, 2021

Conversation

saLeox
Copy link
Contributor

@saLeox saLeox commented Nov 9, 2021

What is the purpose of the change

  1. Fix a ClassNotfoundException issue because of lacking hadoop-mapreduce-client-core dependency in Flink engine pom;
  2. Since Kafka and Json are the more usual used in Flink streaming use case, it's necessary to add on in pom, in case user use them in Flink SQL.

Brief change log

  • Add kafka, json and hadoop-mapreduce-client-core jar in flink engine pom.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 14c86c4 into apache:dev-1.0.3 Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants