Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 1.0.3 bugfix passauthuri add judgement of whether it is empty #1093

Merged
merged 1 commit into from Nov 16, 2021

Conversation

lunescode
Copy link
Contributor

What is the purpose of the change

bugfix:
if the pass auth url set value “”, the method ".getRequestURI.startsWith" will always return true, it is not the result that we wanted, it can be a security risk.

Brief change log

(for example:)

  • Add judgement of whether it is empty

Verifying this change

This change added tests and can be verified as follows:

    1. set wds.linkis.gateway.conf.url.pass.auth="" in linkis-mg-gateway.properties, the restart gateway.
    1. set wds.linkis.server.user.restful.uri.pass.auth="" in linkis-ps-publicservice.properties, the restart publicservice.
    1. curl http://${gateway}/api/rest_j/v1/configuration/getCategory, if return "need login in" will be right.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • Anything that affects deployment: ( no )
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not documented)

if the pass auth url set value “”, the method ".getRequestURI.startsWith" will always return true, it is not the result that we wanted, it can be a security risk.
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit e15827f into apache:dev-1.0.3 Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants