Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VarSubstitutionInterceptor get code type bug fix #1106

Merged
merged 1 commit into from Nov 23, 2021
Merged

VarSubstitutionInterceptor get code type bug fix #1106

merged 1 commit into from Nov 23, 2021

Conversation

zhaoyun006
Copy link
Contributor

What is the purpose of the change

  •      val engineType = LabelUtil.getEngineType(jobRequest.getLabels)
    
  •      val (result, code) = CustomVariableUtils.replaceCustomVar(jobRequest, engineType)
    

val codeType = LabelUtil.getCodeType(jobRequest.getLabels)
val (result, code) = CustomVariableUtils.replaceCustomVar(jobRequest, codeType)

CustomVariableUtils.replaceCustomVar(jobRequest, codeType)

替换变量时,没有拿到code类型,拿到的是引擎类型,造成逻辑永远不成功

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit f5d266a into apache:dev-1.0.3 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants