Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1154 enhance compatibility for MySQL 8.0.3+ #1155

Merged
merged 1 commit into from Dec 7, 2021

Conversation

wayson20
Copy link
Contributor

@wayson20 wayson20 commented Dec 4, 2021

Fix issue #1154: add backticks, enhance compatibility include MySQL 8.0.3+

What is the purpose of the change

word “system” is a reserved word of MySQL 8.0.3+, wrap it in backticks can enhance compatibility.

Brief change log

only add backticks to word "system"

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) (no)

add backticks, enhance compatibility include MySQL 8.0.3+
@wayson20 wayson20 changed the title Update BmlProjectDao.java, fix issue #1154 fix issue #1154 enhance compatibility for MySQL 8.0.3+ Dec 4, 2021
Copy link
Contributor

@wushengyeyouya wushengyeyouya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit c962ece into apache:dev-1.0.3 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants