Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the flink EngineConn and enhance the operator capabilities of ECM module and EC module. #1248

Merged
merged 19 commits into from Dec 28, 2021

Conversation

wushengyeyouya
Copy link
Contributor

What is the purpose of the change

Optimize the flink EngineConn and enhance the operator capabilities of ECM module and EC module.

Brief change log

(for example:)

  • Resolve the problem of fetching progress with no information.
  • Resolve the problem of deploying flink application without yarn appId.
  • Enhance the FlinkOnceJob, support to execute set, show grammar of flinkSQL.
  • Enhance the FlinkOnceJobTest, add the support of using onceJob operators.
  • Since both ECM and EC need Operator module, so the Operator module has been moved to linkis-manager-common.
  • Add the capability of Operator to ECM, so LinkisManager can request to execute ECM Operators by RPC.
  • Add the capability of fetch EC logs from ECM, now we can get all logs of all ECs whenever the EC is running or stopped.
  • Optimize the architecture of LinkisManager, so linkis-computation-client can request LinkisManager to route operator request to ECM.
  • Optimize the logic of EC creation, and fill in more EC information when EC is creating.
  • Delete the EngineConnLogOperator in accessible-executor, since some errors will be throws when the EC is starting or stopped.
  • Add the capability of executing Operators to ECM in linkis-computation-client.

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

  • Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • Anything that affects deployment: (yes / no / don't know)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

… of all ECs whenever the EC is running or stopped.
…ent can request LinkisManager to route operator request to ECM.
…rrors will be throws when the EC is starting or stopped.

The EC log fetch feature has been moved to ECM.
…Manager to redirect log operator to ECM to fetch EC logs.
…v-1.0.3

� Conflicts:
�	linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/scala/org/apache/linkis/manager/am/pointer/DefaultEMNodPointer.scala
�	linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/scala/org/apache/linkis/manager/am/service/em/DefaultEMInfoService.scala
�	linkis-computation-governance/linkis-manager/linkis-manager-commons/linkis-manager-common/src/main/java/org/apache/linkis/manager/common/entity/node/AMEngineNode.java
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 69fd252 into apache:dev-1.0.3 Dec 28, 2021
@sargentti sargentti moved this from Doing to Done in Apache Incubator Linkis 1.0.3 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants