fix:apache#1358 #1469
Merged
fix:apache#1358 #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following statement passes the test: select * from xx where xx like '%abc;def%'; select * from xx where xx like '%abc;d"ef%';select * from xx where xx like '%a;d"ef%'; select * from xx where xx like '%abc;d\;ef%'
|
#1469
发自我的iPhone
…------------------ Original ------------------
From: peacewong ***@***.***>
Date: Thu,Feb 17,2022 8:17 PM
To: apache/incubator-linkis ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [apache/incubator-linkis] fix:apache#1358 (PR #1469)
Merged #1469 into dev-1.1.0-datasource.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
close #1358
Brief change log
-Optimize SqlCodeParser
-Semicolons inside double or single quotation marks are not considered delimiters
Verifying this change
This change added tests and can be verified as follows:
select * from xx where xx like '%abc;def%';
select * from xx where xx like '%abc;d"ef%';select * from xx where xx like '%a;d"ef%';
select * from xx where xx like '%abc;d;ef%';
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): ( no)
Anything that affects deployment: (no)
The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)
Documentation
Does this pull request introduce a new feature? (no)