Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev 1.1.1 run date variables #1733

Merged
merged 2 commits into from Mar 15, 2022
Merged

Dev 1.1.1 run date variables #1733

merged 2 commits into from Mar 15, 2022

Conversation

Fuu3214
Copy link
Contributor

@Fuu3214 Fuu3214 commented Mar 15, 2022

What is the purpose of the change

closes #1732

Brief change log

Added more variables in links-entrance

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

@Fuu3214 Fuu3214 changed the base branch from master to dev-1.1.1 March 15, 2022 09:06
peacewong
peacewong approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit b1410c6 into apache:dev-1.1.1 Mar 15, 2022
@peacewong peacewong deleted the dev-1.1.1-run_date_variables branch March 15, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacewong peacewong peacewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] [entrance] support more run_date based variables
2 participants
@Fuu3214 @peacewong