Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that default configuration for creator won't take effect. #1783

Merged
merged 2 commits into from Mar 23, 2022

Conversation

Alexkun
Copy link
Contributor

@Alexkun Alexkun commented Mar 23, 2022

What is the purpose of the change

close #1764

Brief change log

  • Change request in linkis-application-manager to get all engine's global configurations and user-defined configurations in one request.
  • Fix bug in linkis-configuration to get correct default creator params.

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage. (yes)
This change is already covered by existing tests, such as (please describe tests). (no)
This change added tests and can be verified as follows:
(example:)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no )
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

1. linkis-configuration - fix bug for default creator params
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 1eaeedd into apache:dev-1.1.1 Mar 23, 2022
@peacewong peacewong deleted the dev-1.1.1-fix-conf branch March 23, 2022 13:25
@Alexkun Alexkun restored the dev-1.1.1-fix-conf branch April 1, 2022 08:38
@Alexkun Alexkun deleted the dev-1.1.1-fix-conf branch April 1, 2022 08:42
@Alexkun Alexkun restored the dev-1.1.1-fix-conf branch April 1, 2022 08:42
@Alexkun Alexkun deleted the dev-1.1.1-fix-conf branch April 1, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants