Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIFOUserConsumer ConsumeQueue supports specific users with large capacity #2160

Merged

Conversation

Alexkun
Copy link
Contributor

@Alexkun Alexkun commented May 23, 2022

What is the purpose of the change

issue #2053

Brief change log

(for example:)

  • Add support for specified username to use specified groupCapacity

Verifying this change

(Please pick either of the following options)
(example:)

  • Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2160 (7b9892e) into dev-1.1.3 (c953223) will increase coverage by 1.16%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2160      +/-   ##
===============================================
+ Coverage        18.45%   19.61%   +1.16%     
- Complexity         703      843     +140     
===============================================
  Files              344      383      +39     
  Lines            10723    11820    +1097     
  Branches          1608     1757     +149     
===============================================
+ Hits              1979     2319     +340     
- Misses            8539     9258     +719     
- Partials           205      243      +38     
Impacted Files Coverage Δ
...org/apache/linkis/jobhistory/util/QueryUtils.scala 17.64% <0.00%> (-0.27%) ⬇️
...g/apache/linkis/variable/entity/VarKeyValueVO.java 0.00% <0.00%> (ø)
...linkis/configuration/validate/FloatValidator.scala 11.11% <0.00%> (ø)
...he/linkis/configuration/entity/ConfigKeyValue.java 48.07% <0.00%> (ø)
...e/linkis/configuration/LinkisConfigurationApp.java 0.00% <0.00%> (ø)
...linkis/configuration/service/CategoryService.scala 40.76% <0.00%> (ø)
.../configuration/validate/ValidatorManagerImpl.scala 40.00% <0.00%> (ø)
...pache/linkis/configuration/util/JsonNodeUtil.scala 0.00% <0.00%> (ø)
...nkis/configuration/util/LabelParameterParser.scala 48.38% <0.00%> (ø)
...inkis/variable/restful/api/VariableRestfulApi.java 0.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c953223...7b9892e. Read the comment docs.

@peacewong peacewong merged commit 12c8fac into apache:dev-1.1.3 May 23, 2022
@peacewong peacewong deleted the dev-1.1.2-new-entrance-group-size branch May 23, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants