Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RetryCountLabel and retrycount param #2164

Merged
merged 3 commits into from May 31, 2022

Conversation

Alexkun
Copy link
Contributor

@Alexkun Alexkun commented May 23, 2022

What is the purpose of the change

issue #2154

Brief change log

(for example:)

  • Add RetryCountLabel
  • Add runtime param wds.linkis.computation.orchestrator.retry.max.age

Verifying this change

(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)

  • Submit a task with ether RetryCountLabel or runtime param "wds.linkis.computation.orchestrator.retry.max.age" , and requiring more than left resource , then see the retry count in log.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

2. orchestrator-core - add support for retryCount in RetryExecTask
liuyou2
liuyou2 previously approved these changes May 23, 2022
Copy link
Contributor

@liuyou2 liuyou2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2164 (dc2f741) into dev-1.1.3 (9b019f8) will increase coverage by 1.12%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2164      +/-   ##
===============================================
+ Coverage        18.45%   19.57%   +1.12%     
- Complexity         703      842     +139     
===============================================
  Files              344      383      +39     
  Lines            10723    11820    +1097     
  Branches          1608     1757     +149     
===============================================
+ Hits              1979     2314     +335     
- Misses            8539     9262     +723     
- Partials           205      244      +39     
Impacted Files Coverage Δ
...linkis/jobhistory/restful/api/QueryRestfulApi.java 37.86% <0.00%> (-4.86%) ⬇️
...org/apache/linkis/jobhistory/util/QueryUtils.scala 17.64% <0.00%> (-0.27%) ⬇️
...is/variable/receiver/VariableReceiverChooser.scala 0.00% <0.00%> (ø)
...inkis/variable/restful/api/VariableRestfulApi.java 0.00% <0.00%> (ø)
...e/linkis/configuration/LinkisConfigurationApp.java 0.00% <0.00%> (ø)
.../org/apache/linkis/variable/entity/VarKeyUser.java 100.00% <0.00%> (ø)
...e/linkis/configuration/entity/CategoryLabelVo.java 75.00% <0.00%> (ø)
.../apache/linkis/variable/entity/VarKeyAndValue.java 0.00% <0.00%> (ø)
...pache/linkis/configuration/entity/ConfigValue.java 89.47% <0.00%> (ø)
...g/apache/linkis/variable/entity/VarKeyValueVO.java 0.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b019f8...dc2f741. Read the comment docs.

@@ -0,0 +1,29 @@
package org.apache.linkis.manager.label.entity.entrance;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ASF License header

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 891c300 into apache:dev-1.1.3 May 31, 2022
@peacewong peacewong deleted the dev-1.1.2-new-retry-param branch May 31, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants