Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-2183] upgrade gson due to cve #2182

Merged
merged 4 commits into from May 28, 2022
Merged

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented May 26, 2022

What is the purpose of the change

#2183 gson has a CVE issue

Brief change log

  • upgrade pom.xml

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • Anything that affects deployment: no
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@pjfanning pjfanning changed the title upgrade gson due to cve [issue-2183] upgrade gson due to cve May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #2182 (c679492) into master (9ad722d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2182   +/-   ##
=========================================
  Coverage     19.62%   19.62%           
  Complexity      843      843           
=========================================
  Files           383      383           
  Lines         11819    11819           
  Branches       1757     1757           
=========================================
  Hits           2319     2319           
  Misses         9257     9257           
  Partials        243      243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad722d...c679492. Read the comment docs.

peacewong
peacewong previously approved these changes May 27, 2022
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@casionone casionone changed the base branch from master to dev-1.1.3 May 27, 2022 13:57
@casionone casionone dismissed peacewong’s stale review May 27, 2022 13:57

The base branch was changed.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 159f630 into apache:dev-1.1.3 May 28, 2022
@pjfanning pjfanning deleted the patch-2 branch May 28, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants