Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-2199] Optimize label manager logic to remove label keyValue #2200

Merged
merged 1 commit into from May 31, 2022

Conversation

peacewong
Copy link
Contributor

What is the purpose of the change

#2199

Brief change log

  • Optimize label manager logic to remove label keyValue

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #2200 (3f480c8) into dev-1.1.3 (8299f98) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2200      +/-   ##
===============================================
- Coverage        19.61%   19.13%   -0.49%     
  Complexity         843      843              
===============================================
  Files              383      387       +4     
  Lines            11820    12120     +300     
  Branches          1757     1816      +59     
===============================================
  Hits              2319     2319              
- Misses            9258     9558     +300     
  Partials           243      243              
Impacted Files Coverage Δ
...org/apache/linkis/common/utils/VariableUtils.scala 0.00% <0.00%> (ø)
...g/apache/linkis/common/variable/VariableType.scala 0.00% <0.00%> (ø)
...apache/linkis/common/variable/CustomDateType.scala 0.00% <0.00%> (ø)
...e/linkis/governance/common/utils/ECPathUtils.scala 0.00% <0.00%> (ø)
.../apache/linkis/common/variable/DateTypeUtils.scala 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8299f98...3f480c8. Read the comment docs.

Copy link
Contributor

@liuyou2 liuyou2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@liuyou2 liuyou2 merged commit e92799f into apache:dev-1.1.3 May 31, 2022
Apache Incubator Linkis 1.1.3 automation moved this from In progress to Done May 31, 2022
@peacewong peacewong deleted the dev-1.1.3-label-optimize branch May 31, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants