Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-2144]Privilege linkis cmd shell scripts #2203

Merged
merged 1 commit into from Jun 1, 2022
Merged

[Issue-2144]Privilege linkis cmd shell scripts #2203

merged 1 commit into from Jun 1, 2022

Conversation

legendtkl
Copy link
Contributor

What is the purpose of the change

fix #2144

@legendtkl
Copy link
Contributor Author

Hi, @peacewong , @casionone , would you help review this PR?

Thanks.

Copy link
Contributor

@casionone casionone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a workaround
but with sudo ?

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #2203 (8ab4663) into dev-1.1.3 (e92799f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             dev-1.1.3    #2203   +/-   ##
============================================
  Coverage        19.13%   19.13%           
  Complexity         843      843           
============================================
  Files              387      387           
  Lines            12120    12120           
  Branches          1816     1816           
============================================
  Hits              2319     2319           
  Misses            9558     9558           
  Partials           243      243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92799f...8ab4663. Read the comment docs.

@legendtkl
Copy link
Contributor Author

I think it's a workaround but with sudo ?

Yes.
I tried many ways with the maven plugin, but can't make it.

@casionone casionone changed the title prevelige linkis cmd shell scripts [Issue-2144]Prevelige linkis cmd shell scripts Jun 1, 2022
@casionone casionone changed the title [Issue-2144]Prevelige linkis cmd shell scripts [Issue-2144]Privilege linkis cmd shell scripts Jun 1, 2022
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit d57abbc into apache:dev-1.1.3 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants