Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileReader and BufferedReader are not closed in final clause #2226

Merged

Conversation

wallezhang
Copy link
Contributor

What is the purpose of the change

Fix FileReader and BufferedReader are not closed in final clause. Related issues: #1878 .

Brief change log

(for example:)

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

  • Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Close #1878

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2226 (2bd67bb) into dev-1.1.3 (d57abbc) will increase coverage by 1.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2226      +/-   ##
===============================================
+ Coverage        19.13%   20.14%   +1.01%     
- Complexity         843     1005     +162     
===============================================
  Files              387      425      +38     
  Lines            12120    12926     +806     
  Branches          1816     2035     +219     
===============================================
+ Hits              2319     2604     +285     
- Misses            9558     9977     +419     
- Partials           243      345     +102     
Impacted Files Coverage Δ
.../scala/org/apache/linkis/scheduler/queue/Job.scala 14.21% <0.00%> (ø)
...linkis/scheduler/conf/SchedulerConfiguration.scala 100.00% <0.00%> (ø)
...e/linkis/scheduler/queue/fifoqueue/FIFOGroup.scala 56.25% <0.00%> (ø)
...ler/queue/fifoqueue/FIFOSchedulerContextImpl.scala 73.07% <0.00%> (ø)
...pache/linkis/scheduler/executer/ExecutorInfo.scala 0.00% <0.00%> (ø)
.../scheduler/exception/SchedulerErrorException.scala 100.00% <0.00%> (ø)
...la/org/apache/linkis/scheduler/queue/JobInfo.scala 0.00% <0.00%> (ø)
...org/apache/linkis/scheduler/SchedulerContext.scala 66.66% <0.00%> (ø)
...e/linkis/scheduler/executer/AbstractExecutor.scala 0.00% <0.00%> (ø)
.../scheduler/queue/parallelqueue/ParallelGroup.scala 0.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57abbc...2bd67bb. Read the comment docs.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit efe16ae into apache:dev-1.1.3 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants