Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides clear methods in contextservice #2234

Merged
merged 12 commits into from Jun 7, 2022

Conversation

Alexkun
Copy link
Contributor

@Alexkun Alexkun commented Jun 7, 2022

What is the purpose of the change

#2158
Provides clear methods in contextservice

Brief change log

(for example:)

  • Add create_time、update_time、access_time in all tables in contextservice
  • Add clear-context methods in linkis-cs-server module
  • Add clear-context methods in linkis-cs-client

Verifying this change

(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)

  • Added tests in linkis-cs-client.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yno)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

peacewong
peacewong previously approved these changes Jun 7, 2022
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2234 (0f7b968) into dev-1.1.3 (9b019f8) will increase coverage by 1.68%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2234      +/-   ##
===============================================
+ Coverage        18.45%   20.14%   +1.68%     
- Complexity         703     1005     +302     
===============================================
  Files              344      425      +81     
  Lines            10723    12926    +2203     
  Branches          1608     2035     +427     
===============================================
+ Hits              1979     2604     +625     
- Misses            8539     9977    +1438     
- Partials           205      345     +140     
Impacted Files Coverage Δ
...org/apache/linkis/jobhistory/util/QueryUtils.scala 17.64% <0.00%> (-0.27%) ⬇️
...org/apache/linkis/common/utils/VariableUtils.scala 0.00% <0.00%> (ø)
.../apache/linkis/configuration/entity/ConfigKey.java 72.97% <0.00%> (ø)
...he/linkis/scheduler/executer/ExecuteResponse.scala 0.00% <0.00%> (ø)
...rg/apache/linkis/scheduler/executer/Executor.scala 0.00% <0.00%> (ø)
.../apache/linkis/variable/entity/VarKeyAndValue.java 0.00% <0.00%> (ø)
...onfiguration/exception/ConfigurationException.java 0.00% <0.00%> (ø)
.../configuration/validate/ValidatorManagerImpl.scala 40.00% <0.00%> (ø)
...linkis/scheduler/conf/SchedulerConfiguration.scala 100.00% <0.00%> (ø)
...pache/linkis/configuration/entity/ConfigValue.java 89.47% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b019f8...0f7b968. Read the comment docs.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 5b3b890 into apache:dev-1.1.3 Jun 7, 2022
@peacewong peacewong deleted the dev-1.1.2-new-cs-clear branch June 7, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants