Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resultset path in linkis-entrance #2238

Conversation

Alexkun
Copy link
Contributor

@Alexkun Alexkun commented Jun 7, 2022

What is the purpose of the change

#2124
Refactor resultset path in linkis-entrance

Brief change log

(for example:)

  • Refactor resultset path in linkis-entrance

Verifying this change

(Please pick either of the following options)

This change added tests and can be verified as follows:
(example:)

  • Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (o)
  • Anything that affects deployment: (no )
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2238 (44e4c37) into dev-1.1.3 (ad447ab) will increase coverage by 1.59%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2238      +/-   ##
===============================================
+ Coverage        18.45%   20.04%   +1.59%     
- Complexity         703     1005     +302     
===============================================
  Files              344      425      +81     
  Lines            10723    12988    +2265     
  Branches          1608     2073     +465     
===============================================
+ Hits              1979     2604     +625     
- Misses            8539    10039    +1500     
- Partials           205      345     +140     
Impacted Files Coverage Δ
...org/apache/linkis/jobhistory/util/QueryUtils.scala 17.64% <0.00%> (-0.27%) ⬇️
...org/apache/linkis/common/utils/VariableUtils.scala 0.00% <0.00%> (ø)
...configuration/receiver/ConfigurationReceiver.scala 33.33% <0.00%> (ø)
...e/linkis/configuration/entity/CategoryLabelVo.java 75.00% <0.00%> (ø)
...ache/linkis/configuration/conf/Configuration.scala 100.00% <0.00%> (ø)
.../linkis/variable/service/VariableServiceImpl.scala 28.00% <0.00%> (ø)
...ava/org/apache/linkis/variable/entity/VarTree.java 0.00% <0.00%> (ø)
.../apache/linkis/configuration/entity/ConfigKey.java 72.97% <0.00%> (ø)
...e/parallelqueue/ParallelSchedulerContextImpl.scala 100.00% <0.00%> (ø)
...ler/queue/parallelqueue/ParallelGroupFactory.scala 66.66% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad447ab...44e4c37. Read the comment docs.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 4e5d5b9 into apache:dev-1.1.3 Jun 7, 2022
@peacewong peacewong deleted the dev-1.1.2-new-fix-entrance-resultset-path branch June 7, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants