Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ECM should be add to the last of the choice array. #2243

Merged
merged 1 commit into from Jun 8, 2022

Conversation

Alexkun
Copy link
Contributor

@Alexkun Alexkun commented Jun 8, 2022

What is the purpose of the change

#2242

  1. add NewECMStandbyRule

Brief change log

(for example:)

  • Define the NewECMStandbyRule in the linkis-applicationmanager module.

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #2243 (16b2806) into dev-1.1.3 (adfc902) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2243      +/-   ##
===============================================
- Coverage        20.14%   20.13%   -0.02%     
  Complexity        1005     1005              
===============================================
  Files              425      426       +1     
  Lines            12926    12935       +9     
  Branches          2035     2037       +2     
===============================================
  Hits              2604     2604              
- Misses            9977     9986       +9     
  Partials           345      345              
Impacted Files Coverage Δ
...inkis/jobhistory/conversions/TaskConversions.scala 8.37% <0.00%> (-0.20%) ⬇️
...rnance/common/constant/job/TaskInfoConstants.scala 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfc902...16b2806. Read the comment docs.

@peacewong peacewong merged commit d3e2ca6 into apache:dev-1.1.3 Jun 8, 2022
@peacewong peacewong deleted the dev-1.1.3-ecm-wait branch June 8, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants