Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-2318] Change ENABLE METADATA MANAGE default from false to true #2319

Merged
merged 2 commits into from Jun 24, 2022

Conversation

casionone
Copy link
Contributor

What is the purpose of the change

  1. remove unused token.properties
  2. change ENABLE_METADATA_MANAGE default as true
  3. fix dml.sql

2. change ENABLE_METADATA_MANAGE default as true
3. fix dml
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #2319 (aceab4f) into dev-1.1.3 (06267f6) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2319      +/-   ##
===============================================
- Coverage        20.22%   19.75%   -0.48%     
+ Complexity        1022     1006      -16     
===============================================
  Files              440      440              
  Lines            13149    13149              
  Branches          2088     2088              
===============================================
- Hits              2660     2597      -63     
- Misses           10140    10211      +71     
+ Partials           349      341       -8     
Impacted Files Coverage Δ
...he/linkis/cli/core/exception/CommandException.java 0.00% <0.00%> (-100.00%) ⬇️
.../linkis/cli/core/exception/error/CommonErrMsg.java 0.00% <0.00%> (-93.94%) ⬇️
...ava/org/apache/linkis/cli/core/utils/LogUtils.java 0.00% <0.00%> (-60.00%) ⬇️
...ore/exception/handler/CommandExceptionHandler.java 9.09% <0.00%> (-45.46%) ⬇️
...ore/exception/handler/DefaultExceptionHandler.java 0.00% <0.00%> (-31.43%) ⬇️
...li/core/interactor/command/CmdTemplateFactory.java 0.00% <0.00%> (-15.39%) ⬇️
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 34.44% <0.00%> (+1.11%) ⬆️
...a/org/apache/linkis/scheduler/queue/Consumer.scala 71.42% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06267f6...aceab4f. Read the comment docs.

Copy link
Contributor

@jacktao007 jacktao007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit ebb2715 into apache:dev-1.1.3 Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants