Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Automatically create workspace for newly added users #2368

Merged
merged 3 commits into from Jun 29, 2022
Merged

[Feature] Automatically create workspace for newly added users #2368

merged 3 commits into from Jun 29, 2022

Conversation

hunter-cloud09
Copy link
Contributor

@hunter-cloud09 hunter-cloud09 commented Jun 29, 2022

What is the purpose of the change

Automatically create workspace for newly added users

Brief change log

By adding linkis.workspace.filesystem.auto.create.workspace=true, the current user's workspace and hdfs root dir can be created automatically

Verifying this change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • Anything that affects deployment: no
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@hunter-cloud09 hunter-cloud09 changed the title Dev 1.2.0 auto create [Feature] Automatically create workspace for newly added users Jun 29, 2022
@@ -55,6 +55,9 @@ public class WorkSpaceConfiguration {
public static final CommonVars<Boolean> FILESYSTEM_PATH_CHECK_OWNER =
CommonVars$.MODULE$.apply("wds.linkis.workspace.filesystem.owner.check", false);

public static final CommonVars<Boolean> FILESYSTEM_PATH_AUTO_CREATE =
CommonVars$.MODULE$.apply("wds.linkis.workspace.filesystem.auto.create", false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove prefix wds

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #2368 (62eb671) into dev-1.2.0 (3031296) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.2.0    #2368      +/-   ##
===============================================
- Coverage        18.60%   18.59%   -0.01%     
+ Complexity        1060     1059       -1     
===============================================
  Files              544      544              
  Lines            16690    16690              
  Branches          2495     2495              
===============================================
- Hits              3105     3104       -1     
- Misses           13153    13154       +1     
  Partials           432      432              
Impacted Files Coverage Δ
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 33.33% <0.00%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3031296...62eb671. Read the comment docs.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 713f4c5 into apache:dev-1.2.0 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants