Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #2348 jdbc engine support trino #2392

Merged
merged 1 commit into from Jul 3, 2022
Merged

[feature] #2348 jdbc engine support trino #2392

merged 1 commit into from Jul 3, 2022

Conversation

huapan123456
Copy link
Contributor

What is the purpose of the change

add a result type to jdbc engine

Brief change log

(for example:)

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

  • Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #2392 (4fa4804) into dev-1.2.0 (84a48a0) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##             dev-1.2.0    #2392      +/-   ##
===============================================
- Coverage        17.78%   17.78%   -0.01%     
  Complexity        1077     1077              
===============================================
  Files              595      595              
  Lines            17668    17669       +1     
  Branches          2673     2674       +1     
===============================================
- Hits              3143     3142       -1     
- Misses           14092    14093       +1     
- Partials           433      434       +1     
Impacted Files Coverage Δ
...eplugin/jdbc/executer/JDBCEngineConnExecutor.scala 12.90% <0.00%> (-0.09%) ⬇️
...a/org/apache/linkis/scheduler/queue/Consumer.scala 57.14% <0.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a48a0...4fa4804. Read the comment docs.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 31d9a1a into apache:dev-1.2.0 Jul 3, 2022
@huapan123456 huapan123456 deleted the dev-1.2.0-feature-2348 branch July 4, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants