Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(spark): get scala version from util.properties.versionNumber… #2419

Merged
merged 2 commits into from Jul 8, 2022

Conversation

jackxu2011
Copy link
Contributor

…String

What is the purpose of the change

remove the config SPARK_SCALA_VERSION and get the scalaVersion from env

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • Anything that affects deployment: no
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #2419 (95e33bc) into dev-1.2.0 (10ee01d) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.2.0    #2419      +/-   ##
===============================================
- Coverage        17.83%   17.78%   -0.06%     
+ Complexity        1077     1074       -3     
===============================================
  Files              595      595              
  Lines            17667    17667              
  Branches          2635     2635              
===============================================
- Hits              3151     3142       -9     
- Misses           14092    14102      +10     
+ Partials           424      423       -1     
Impacted Files Coverage Δ
...la/org/apache/linkis/scheduler/queue/UserJob.scala 16.66% <0.00%> (-16.67%) ⬇️
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 33.33% <0.00%> (-4.45%) ⬇️
...apache/linkis/scheduler/queue/LoopArrayQueue.scala 32.07% <0.00%> (-1.89%) ⬇️
.../scala/org/apache/linkis/scheduler/queue/Job.scala 14.72% <0.00%> (-1.02%) ⬇️
...apache/linkis/scheduler/queue/SchedulerEvent.scala 52.94% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ee01d...95e33bc. Read the comment docs.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit fc3be7d into apache:dev-1.2.0 Jul 8, 2022
@jackxu2011 jackxu2011 deleted the feat-getScalaVersionByCode branch July 8, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants