Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-2970]exclude netty-3.6.2.Final.jar dependencies #2971

Merged
merged 2 commits into from Aug 24, 2022

Conversation

binbinCheng
Copy link
Contributor

exclude netty-3.6.2.Final.jar dependencies
Related issue #2970

@casionone
Copy link
Contributor

lib/linkis-engineconn-plugins/jdbc/dist/v4/lib/netty-3.6.2.Final.jar
lib/linkis-public-enhancements/linkis-ps-metadataquery/service/hive/netty-3.6.2.Final.jar

linkis-commons/linkis-storage/pom.xml

<dependency>
      <groupId>org.apache.linkis</groupId>
      <artifactId>linkis-hadoop-common</artifactId>
      <version>${project.version}</version>
      <exclusions>
        <exclusion>
          <groupId>com.google.protobuf</groupId>
          <artifactId>protobuf-java</artifactId>
        </exclusion>
        <exclusion>
          <artifactId>netty</artifactId>
          <groupId>io.netty</groupId>
        </exclusion>
      </exclusions>
</dependency> 

this pom dependency need to excluded

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #2971 (496f59d) into dev-1.3.1 (393fb5e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.3.1    #2971      +/-   ##
===============================================
- Coverage        15.93%   15.92%   -0.01%     
+ Complexity        1336     1335       -1     
===============================================
  Files              742      742              
  Lines            24517    24517              
  Branches          3481     3481              
===============================================
- Hits              3907     3905       -2     
- Misses           20104    20106       +2     
  Partials           506      506              
Impacted Files Coverage Δ
...apache/linkis/scheduler/queue/LoopArrayQueue.scala 30.90% <0.00%> (-1.82%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@casionone casionone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casionone casionone changed the title exclude netty-3.6.2.Final.jar dependencies [ISSUE-2970]exclude netty-3.6.2.Final.jar dependencies Aug 24, 2022
@casionone casionone merged commit 989054a into apache:dev-1.3.1 Aug 24, 2022
@binbinCheng binbinCheng deleted the dev-1.3.1-renetty branch August 25, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants