Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OnceECClient][LinkisManager]Once job client obtains EngineConn information, it should use ticketId as the unique key #3741

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

peacewong
Copy link
Contributor

What is the purpose of the change

Once you need to obtain the status information of the EC to determine whether the EC exits normally, but the current way to obtain it is through serviceInstance. Since the information is not unique by the IP and port, it will result in the acquisition of multiple EC information, resulting in an error. . In this fix, it is recommended to use ticketid to obtain, this is the unique key of UUID

Related issues/PRs

Related issues: #3718

Brief change log

  • Once job client obtains EngineConn information by ticket id;
  • Fix once client NPE exception.
  • EC exit All labels of EC should be cleaned up

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@casionone casionone merged commit 7c3627b into apache:dev-1.3.1 Nov 1, 2022
@peacewong peacewong deleted the dev-1.3.2-once-client-fix branch November 3, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants