[feat] EngineConn no longer imports the dependencies of the underlying engine #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoPhilipse
changed the title
peacewong
approved these changes
Mar 4, 2023
| @@ -33,8 +33,6 @@ import java.util.concurrent.TimeUnit | |||
| import scala.concurrent.{Await, ExecutionContext, Future} | |||
| import scala.concurrent.duration.Duration | |||
|
|
|||
| import org.json4s._ | |||
|
|
|||
| /** | |||
| */ | |||
| abstract class ProcessInterpreter(process: Process) extends Interpreter with Logging { | |||
There was a problem hiding this comment.
can delete ProcessInterpreter，No longer use
There was a problem hiding this comment.
seems PythonInterpreter still extends from ProcessInterpreter
private class PythonInterpreter(process: Process, gatewayServer: GatewayServer)
extends ProcessInterpreter(process)
with Logging {
There was a problem hiding this comment.
@GuoPhilipse Yes, but it is no longer used, we can remove inheritance and remove unused methods
…nused method from PythonInterpreter.scala
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
EngineConn no longer imports the dependencies of the underlying engine. and remove json4s from ec to reduce engine dependency
Related issues/PRs
Related issues: #4186
Related pr:#4278
Brief change log
Checklist