[WIP] remove json4s from linkis #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackxu2011 @rarexixi please help review |
jackxu2011
requested changes
Mar 16, 2023
...utation-client/src/main/scala/org/apache/linkis/ujes/client/response/JobProgressResult.scala
Outdated
Show resolved
Hide resolved
| ) | ||
| def getYarnResource(resource: Option[Any]) = resource.map(r => { | ||
| val value = | ||
| JsonUtils.jackson.readValue(r.asInstanceOf[YarnResource].toJson, classOf[Map[String, Any]]) |
There was a problem hiding this comment.
is the json is useless, just cast the resource to YarnResource?
There was a problem hiding this comment.
have given up this method, reduce json parse times.
...anager/src/main/scala/org/apache/linkis/manager/rm/external/yarn/YarnResourceRequester.scala
Outdated
Show resolved
Hide resolved
jackxu2011
requested changes
Mar 17, 2023
...anager/src/main/scala/org/apache/linkis/manager/rm/external/yarn/YarnResourceRequester.scala
Outdated
Show resolved
Hide resolved
linkis-computation-governance/linkis-manager/linkis-application-manager/pom.xml
Outdated
Show resolved
Hide resolved
peacewong
reviewed
Mar 18, 2023
| @@ -298,9 +297,9 @@ class DefaultEngineCreateService | |||
| resource, | |||
| timeout | |||
| ) match { | |||
| case AvailableResource(ticketId) => | |||
There was a problem hiding this comment.
Why do we need to return Json here?
There was a problem hiding this comment.
seems it is used for getting resource [resourceTicketId, resource] info if we got enough resource, or we will throw not enough resource.
val emNode = choseNode.get.asInstanceOf[EMNode]
// 4. 请求资源
val (resourceTicketId, resource) =
requestResource(engineCreateRequest, labelFilter.choseEngineLabel(labelList), emNode, timeout)
// 5. 封装engineBuildRequest对象,并发送给EM进行执行
val engineBuildRequest = EngineConnBuildRequestImpl(
resourceTicketId,
labelFilter.choseEngineLabel(labelList),
resource,
EngineConnCreationDescImpl(
engineCreateRequest.getCreateService,
engineCreateRequest.getDescription,
engineCreateRequest.getProperties
)
)
peacewong
reviewed
Mar 20, 2023
| 0d | ||
| val absoluteCapacity = JsonPath.read(r, "$.absoluteCapacity") | ||
|
|
||
| if (absoluteCapacity.isInstanceOf[BigDecimal]) { |
There was a problem hiding this comment.
The judgment here is not assigned a value in the end. Is it necessary to judge BigDecimal here?
There was a problem hiding this comment.
have changed to assign the value while judging datatype.
| val app = ctx.read("$.apps.app") | ||
|
|
||
| val queueValue = ctx.read("$.apps.app.queue").asInstanceOf[String] | ||
| val stateValue = ctx.read("$.apps.app.state").asInstanceOf[String] |
| } | ||
|
|
||
| def serializeResource(resource: Resource): String = { | ||
| write(resource) | ||
| JsonUtils.jackson.writeValueAsString(resource, classOf[Map[String, Any]]) |
There was a problem hiding this comment.
Why do we need to specify the type?
GuoPhilipse
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
use jackson to replace json4s, we can reduce the linkis dependency
Related issues/PRs
Related issues: #4186
Related pr:#4368
Brief change log
Checklist