Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECM code optimization #4449

Merged
merged 8 commits into from Apr 16, 2023
Merged

Conversation

ChengJie1053
Copy link
Member

What is the purpose of the change

EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection
and session management.

Related issues/PRs

Related issues: #590
Related pr:#591

Brief change log

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

.get(
user,
DateFormatUtils.format(System.currentTimeMillis(), "yyyyMMdd"),
if (StringUtils.isBlank(engineType)) "" else engineType
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
If empty skip

@peacewong peacewong closed this Apr 9, 2023
@peacewong peacewong reopened this Apr 9, 2023
peacewong
peacewong previously approved these changes Apr 9, 2023
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong changed the title ECM code optimization [WIP]ECM code optimization Apr 10, 2023
@peacewong peacewong closed this Apr 15, 2023
@peacewong peacewong reopened this Apr 15, 2023
@peacewong peacewong changed the title [WIP]ECM code optimization ECM code optimization Apr 16, 2023
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit c8d1512 into apache:dev-1.4.0 Apr 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants