New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feate] Added support for postgresql based on dev-1.4.0 #4524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the mysql mapper file to resources/mapper/mysql, pgsql to resources/mapper/postgresql, and if the sql file is same, keep the file in the resources/common/.
...vernance/linkis-manager/linkis-application-manager/src/test/resources/application.properties
Outdated
Show resolved
Hide resolved
...vernance/linkis-manager/linkis-application-manager/src/test/resources/application.properties
Outdated
Show resolved
Hide resolved
wds.linkis.log.clear=true | ||
wds.linkis.server.version=v1 | ||
##mybatis | ||
wds.linkis.server.mybatis.mapperLocations=classpath*:org/apache/linkis/manager/dao/impl/*.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if have *.xml in package, move to the /mapper/common, or database specific locations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion. I have modified it according to your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the config should be modified
...s-application-manager/src/main/resources/mapper/common/mysql/EngineConnBmlResourceMapper.xml
Outdated
Show resolved
Hide resolved
...plication-manager/src/main/resources/mapper/common/mysql/ExternalResourceProviderDaoImpl.xml
Outdated
Show resolved
Hide resolved
...lication-manager/src/main/resources/mapper/common/postgresql/EngineConnBmlResourceMapper.xml
Outdated
Show resolved
Hide resolved
Please resolve the conflict |
.../linkis-application-manager/src/main/resources/mapper/common/EngineConnBmlResourceMapper.xml
Outdated
Show resolved
Hide resolved
.../linkis-application-manager/src/main/resources/mapper/common/EngineConnBmlResourceMapper.xml
Outdated
Show resolved
Hide resolved
.../linkis-application-manager/src/main/resources/mapper/common/EngineConnBmlResourceMapper.xml
Outdated
Show resolved
Hide resolved
.../linkis-application-manager/src/main/resources/mapper/common/EngineConnBmlResourceMapper.xml
Outdated
Show resolved
Hide resolved
...r/linkis-manager-persistence/src/main/resources/mapper/postgresql/ECResourceRecordMapper.xml
Outdated
Show resolved
Hide resolved
...bel/linkis-instance-label-server/src/main/resources/mapper/postgresql/InstanceInfoMapper.xml
Outdated
Show resolved
Hide resolved
...el/linkis-instance-label-server/src/main/resources/mapper/postgresql/InstanceLabelMapper.xml
Outdated
Show resolved
Hide resolved
...lic-enhancements/linkis-jobhistory/src/main/resources/mapper/postgresql/JobHistoryMapper.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping @peacewong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Related issues/PRs
Brief change log
How to use postgresql
Checklist