Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reuseEngine may throw NullPointerException exception(#4662) #4663

Merged
merged 1 commit into from Jun 19, 2023

Conversation

CharlieYan24
Copy link
Contributor

@CharlieYan24 CharlieYan24 commented Jun 19, 2023

What is the purpose of the change

EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection
and session management.

Related issues/PRs

Related issues: #4662
Related pr:#4662

Brief change log

  • Use List as parameter in method selectEngineToReuse instead .

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@CharlieYan24 CharlieYan24 changed the title fix: reuseEngine may throw NullPointerException exception #4662 fix: reuseEngine may throw NullPointerException exception(#4662) Jun 19, 2023
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aiceflower
Copy link
Contributor

LGTM.

@casionone casionone merged commit 1149374 into apache:dev-1.4.0 Jun 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants