Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add nebula engine to linkis #4903

Merged
merged 5 commits into from Sep 20, 2023

Conversation

ChengJie1053
Copy link
Member

Reference 'linkis-engineplugin-presto' module, add 'linkis-engineplugin-nebula' module

@ChengJie1053 ChengJie1053 changed the title [WIP][Feature] Add nebula engine to linkis [Feature] Add nebula engine to linkis Sep 13, 2023
public class NebulaConfiguration {

public static final CommonVars<Integer> ENGINE_CONCURRENT_LIMIT =
CommonVars.apply("wds.linkis.engineconn.concurrent.limit", 100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove wds prefix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for reviewing the code

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 4ecb22e into apache:master Sep 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants