Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix weak password in linkis gateway #925

Merged
merged 1 commit into from Aug 15, 2021

Conversation

FireFoxAhri
Copy link
Contributor

What is the purpose of the change

Fix the weak password in linkis gateway.

Related issues: #924.

Brief change log

  • Add a configuration item ADMIN_PASSWORD and a default strong password.
  • Use ADMIN_PASSWORD to validate the password.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@peacewong peacewong changed the base branch from dev-1.1.0 to dev-1.0.2 August 15, 2021 03:06
@@ -37,6 +37,7 @@ object GatewayConfiguration {

val ADMIN_USER = CommonVars("wds.linkis.admin.user", "hadoop")

val ADMIN_PASSWORD = CommonVars("wds.linkis.admin.password", "9br01wloKk9cKkuX")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to modify the default value to the username, set to: ADMIN_USER.getValue

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit c8cec90 into apache:dev-1.0.2 Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants