Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FlinkOnceJobTest.java #981

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Update FlinkOnceJobTest.java #981

merged 1 commit into from
Aug 30, 2021

Conversation

Fuu3214
Copy link
Contributor

@Fuu3214 Fuu3214 commented Aug 30, 2021

fixed a compilation error

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • Anything that affects deployment: ( no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Update FlinkOnceJobTest.java
02ee70f 
fixed a compilation error
@Fuu3214 Fuu3214 requested a review from peacewong August 30, 2021 09:21
peacewong
peacewong approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 92a1608 into dev-1.0.2 Aug 30, 2021
@wushengyeyouya wushengyeyouya deleted the Fuu3214-dev-1.0.2 branch September 1, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacewong peacewong peacewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fuu3214 @peacewong