FLUME-3083. Check byte position of file in update condition of Taildir Source #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to help review this? Satoshi reviewed it in the linked ticket. |
|
@eskrm : sure, it's on my backlog. I'll do my best to prioritise this ticket. |
|
I have done a quick review, ran the tests and it all seems fine. I'll leave some time for others to leave review comments if they have any. |
…r Source This patch addresses an edge case of the Taildir Source wherein it can miss reading events written in the same second as the file closing.
eskrm
changed the title
|
@bessbd Thanks. Squashed and added more detail to the commit message. |
|
@bessbd Ready to merge? |
|
LGTM, +1 I'm about to commit this |
|
Thanks @bessbd |
|
@eskrm : thank you for the patch! |
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
stream-diagnostics: fix dependency conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve an edge case where events can be missed during tail file close. More details are provided at https://issues.apache.org/jira/browse/FLUME-3083.